[SeqLaz]

This PR informs the users if the QGIS project has unsaved changes before packaging (Cable) or uploading (Cloud), and provides an interactive "Save project changes now" checkbox directly inside the project checker feedback table to save the project on the spot.

fix_action_callable_qfieldsync.webm

it requires this PR from libqfield

[duke-nyuki]

Task linked: QF-1811 Suggest saving the project before uploading/packaging in QFieldSync project checker feedback screen

[SeqLaz]

@suricactus I've refactor it as you suggested

[suricactus]

Can we add a "Fix!" button on the right end of each feedback line, and then only run the callback when it is clicked. Compared to now, where the checkbox and the callback on toggled lives within the handler.

[SeqLaz]

Can we add a "Fix!" button on the right end of each feedback line, and then only run the callback when it is clicked. Compared to now, where the checkbox and the callback on toggled lives within the handler.

@suricactus I've refactor it, and update the video on the PR description

[suricactus]

Getting there. The video looks very promising!

[suricactus]

@SeqLaz any plans to work on this? Note the CI is also failing.

[SeqLaz]

@SeqLaz any plans to work on this? Note the CI is also failing.

@suricactus the failing CI is due to we need to merge this PR on libqfieldsync first, then add to the requirements.txt.

[suricactus]

Thanks!
@SeqLaz the CI is still failing.

@gounux can you also give a quick review, anyways you are on the QFieldSync topic.

[SeqLaz]

@suricactus the CI is green now!.... Let's wait @gounux review!

[gounux]

Thanks @SeqLaz, also for the video :)

LGTM, just wondering if the Fix! text button might be a bit too "magical" here, I could suggest something like "Save Project", though maybe it would require more deeper works in the new fix "framework".

So, leaving it up to you to take this into consideration or not 👌

[gounux]

Oh also @SeqLaz there are some conflicts in the requirements.txt to fix,

[suricactus]

LGTM, just wondering if the Fix! text button might be a bit too "magical" here, I could suggest something like "Save Project", though maybe it would require more deeper works in the new fix "framework".

Let's keep the majic as "fix" for now, it's per my request.

[suricactus]

@SeqLaz can you please update the dependency here to the latest libqfieldsync to resolve the conflict? If @gounux is going to release, I think you can do that too, depends who is faster :)

[suricactus]

It was simple enough, I did it myself.

[SeqLaz]

Great, many thanks @gounux and @suricactus! 🥷 🥷

[suricactus]

I am ok to merge, please go ahead!

[SeqLaz]

Let me do a final review and then I will merge it @suricactus! 🦾

[SeqLaz]

All good, time to merge! 🦾