Repository navigation
Keep Zinc-Character-Encoding-Core free of later packages - #167
Merged
Merged
Conversation
ZnPercentEncoder read the #urlAsIri option from ZnCurrentOptions in Zinc-Resource-Meta-Core, which itself requires Zinc-Character-Encoding-Core, and the package extended SocketStream from Network-Kernel. The encoder now carries the IRI choice, set from the option by ZnResourceMetaUtils and ZnDataUrl, and the SocketStream extensions move to Zinc-HTTP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thx, Gabriel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZnPercentEncoder >> #urlAsIrireadsZnCurrentOptionsfrom Zinc-Resource-Meta-Core, which itself requires Zinc-Character-Encoding-Core, so each package depends on the other. Zinc-Character-Encoding-Core also extendsSocketStreamfrom Network-Kernel.Loading everything together hides it. Pharo builds Zinc-Character-Encoding-Core into its bootstrapped kernel and loads the other two later, so syncing these changes into Pharo broke its bootstrap (pharo-project/pharo#20131, reverted by pharo-project/pharo#20143).
The encoder now carries the IRI choice in
#urlAsIri:, false by default like#decodePlusAsSpace, andZnResourceMetaUtilsandZnDataUrlset it from the option. TheSocketStreamextensions move to Zinc-HTTP, which already depends on Network-Kernel.One difference:
String >> #urlEncodedand#urlDecodedno longer follow#urlAsIri;ZnUrldoes.Not changed here:
ZnUtils class >> #signalProgress:total:sends#humanReadableSIByteSize, which no Pharo from 11 to 15 implements on numbers (they have#humanReadableSISizeString), so downloading a body of unknown size fails when progress is signalled.