Repository navigation
Conversation
fixes #242 Adds --influx-buffer (config: influx.buffer), a duration for which readings are kept in memory and retried when InfluxDB cannot be reached. The client already batches writes and keeps a retry queue; with a buffer set, retries become unbounded and the queue is sized to hold the batches of that duration, dropping the oldest once full. Without the option the client default of 5 retries within 3 minutes stays in effect. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Not gonna merge. A parameter is too ugly to do. |
Closed
isarrider
added a commit
to isarrider/mbmd
that referenced
this pull request
Nov 2, 2026
influx: use upstream buffering (volkszaehler#406) and add tests
Contributor
|
Added tests... |
Contributor
|
Continued in #413: your commit from here, unchanged and rebased onto current master, plus tests (buffer options, an outage with and without buffer) and a clearer description of the default. Thanks for the implementation! |
isarrider
pushed a commit
to isarrider/mbmd
that referenced
this pull request
Nov 16, 2026
The influx row now points at the open upstream PR volkszaehler#413 and notes that andig rejected a parameter for this in volkszaehler#406. A new table lists every upstream PR from this fork, what it was and where closed ones continued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmuA1dQ8QTTW8pao9KcJS2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #242
Adds
--influx-buffer(config keyinflux.buffer), a duration such as1h. While InfluxDB is unreachable, readings are kept in memory and retried for that long instead of being dropped after the client default of 5 retries within 3 minutes.The influxdb-client-go write API already batches points once per flush interval and keeps a retry queue, so this only configures it: retries become unbounded and the retry queue is sized to hold the batches produced during the buffer duration (the queue counts batches,
RetryBufferLimit / BatchSize). Once full, the oldest batch is discarded, so memory stays bounded by the actual data rate times the buffer duration. Without the option nothing changes.🤖 Generated with Claude Code