Repository navigation
Conversation
fixes volkszaehler#242 Adds --influx-buffer (config: influx.buffer), a duration for which readings are kept in memory and retried when InfluxDB cannot be reached. The client already batches writes and keeps a retry queue; with a buffer set, retries become unbounded and the queue is sized to hold the batches of that duration, dropping the oldest once full. Without the option the client default of 5 retries within 3 minutes stays in effect. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- TestInfluxBufferOptions checks the retry queue size, retry count and retry time derived from the buffer duration, including the client defaults for 0 and the one-batch minimum - TestInfluxOutage simulates a 20s database outage against a fake server and checks that every point is delivered with a 1h buffer - TestInfluxOutageDefault checks that the same outage loses data with the client defaults, so the outage test is meaningful The outage tests are skipped with -short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XzyNHxELw6PasHKku3kreU
Without a buffer the client retries 5 times within 3 minutes but only keeps 10 batches of points, about 10 seconds of data at one flush per second. Say both in the flag help and the example config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmuA1dQ8QTTW8pao9KcJS2
This was referenced Nov 4, 2026
isarrider
pushed a commit
to isarrider/mbmd
that referenced
this pull request
Nov 16, 2026
The influx row now points at the open upstream PR volkszaehler#413 and notes that andig rejected a parameter for this in volkszaehler#406. A new table lists every upstream PR from this fork, what it was and where closed ones continued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmuA1dQ8QTTW8pao9KcJS2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is andig's implementation from #406, unchanged and rebased onto current master, plus tests and a clearer description of the default.
From #406 (andig)
--influx-buffer/influx.bufferkeeps unsent readings in memory and retries them for that long while InfluxDB is unavailable, e.g.1h.Added
server/influx_test.go:0keeps the client default of 5 retries within 3 minutes, which holds about 10 seconds of data.🤖 Generated with Claude Code