Repository navigation
Conversation
…onger satisfied (#81) When a declared requirement is satisfied by a distribution of the dependency directory, the PLAN now also checks its Requires-Dist, with markers and the requested extras, recursively with memoization and cycle protection, against what the dependency directory and the environment hold, so that a requirement replaced by another version declared by another snippet makes the installer resolve the dependency again. A URL requirement of an installed distribution counts as satisfied by a distribution installed from the same URL, whatever its revision or content, so that it is not installed again on every use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
… checking installed requirements (#81) A requirement whose marker mentions extra is followed only for a requested extra, as uv and pip before 23.1 never install one of extra == "", which was planned missing on every use. An installed version which is not PEP 440, like 1.1build1 of a Debian package, satisfies a requirement, instead of failing the plan with InvalidVersion. The distributions, their versions and requirements are read once per name. The README tells about the check of the requirements of installed dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
…ents (#81) An installer can tell a requested extra by another normalization than the one of PLAN, or not at all without Provides-Extra, so a requirement of a requested extra which it never installs was planned missing on every use. Like before, the requirements of extras are not checked (#47). Each declared dependency is looked up once, and the README tells that a distribution of the environment no longer satisfying a requirement fails the installation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
…metadata once (#81) The declared requirement and the requirement of an installed distribution share one check of the version, which accepts a version not of PEP 440, like 1.1build1 of a Debian package, which packaging 22 to 24 failed to compare with InvalidVersion, failing the plan. The metadata of a distribution is parsed once, for its version and requirements. The README tells that the installation is attempted and fails with the conflict when the unsatisfied requirement cannot be installed, and that code with conflicting requirements replaces the versions back and forth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
Keep the is_imported of #79 for the constraints of the imported distributions, with the is_in_dependencies helper of #81, and let writeDistInfo of the tests take both the topLevel content and record of #79 and the requires and directUrl of #81. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
Stacked on #91 (fix of #79) → #82 (fix of #59) → #70 (fix of #25) — merge #70, then #82, then #91, then this one (bottom-up, see CLAUDE.md).
The PLAN script took a requirement satisfied by an installed distribution of the dependency directory without looking at that distribution's own requirements —
so a dependency installed earlier with an older, now unsatisfiable dependency of its own was kept, and the missing or incompatible transitive requirement surfaced only at import time.
Now a satisfied installed distribution is checked recursively: each of its
Requires-Dist(whose environment marker applies) must be satisfied too, otherwise the requirement counts as missing and goes to the installer.extra == "…") are skipped by design — which extras were requested is not recorded in the dist-info (see Extras of an installed dependency are never installed #47).accepts_versionhelper decides whether an installed version satisfies a specifier, for the top-level and the transitive check alike — it also fixes a pre-existing crash on an installed version which is not a valid PEP 440 version (InvalidVersion).METADATAis read once per distribution; the egg-inforequires.txtfallback was dropped (installs into the dependency directory always write.dist-info).Merged with the final state of #79 (
81fbe21):./gradlew buildpasses on Python 3.12, and thePythonDependenciestests on 3.10.Review
3 rounds; the last one found no blocking issues, and the remaining polish was applied (shared
accepts_version, oneMETADATAread, README, cleanups).🤖 Generated with Claude Code
https://claude.ai/code/session_01FJmHQ3jHRbVdpwUiNUkApG