Repository navigation
fix(eic): regenerate soft-deleted compounds and samples on tolerance change - #214
Closed
Jack-Coutts wants to merge 6 commits into
Closed
Jack-Coutts wants to merge 6 commits into
Jack-Coutts wants to merge 6 commits into
Conversation
…change Restore only flips the deleted flag, so items skipped by regeneration came back with no EICs or old-tolerance EICs. Regenerate and correct them too. Refs #168
Regeneration skipped deleted samples with a missing CDF, so restoring one exposed old-tolerance EICs. Flag such samples and refuse to restore them. Refs #168
Restoring a compound exposed its old-tolerance EICs in any active sample whose CDF was missing at the last tolerance change. Refuse such restores from the recovery dialog and session import, before anything changes. Refs #168
Collaborator
Author
|
Replaced by #306, which re-applies this fix onto main after the UI redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Restored compounds lose their EICs after a mass tolerance change.
Restore only flips the deleted flag, so items skipped by regeneration came back with no EICs or old-tolerance EICs. Regenerate and correct them too.
What changed
Scope
Verification
uv run pytest: the full suite passes, except the offscreen-font test intests/test_toolbar_pills.py, which also fails on main.src/reverted to its base (the others guard behaviour main already had).Closes #168