Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🐕 Shuni ReviewNo new issues found. 🤖 Model: Review scope: Full review Reviewed files (2)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talaharoni
reviewed
Oct 21, 2026
| // JWTBearerSettings: Optional JWT Bearer settings which used to validate external token. | ||
| // ClientType: Optional client authentication model, "confidential" or "public". | ||
| // ClientType: Optional client authentication model, "confidential" or "public". If empty on create, newer | ||
| // accounts get "confidential" and older ones the legacy unspecified mode. |
Member
There was a problem hiding this comment.
i guess customers will ask themselves how can they know if they are new or not and we don't have answer for that..
consider re-phrasing somehow?
(if changing do it for other SDK PRs as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/19288
Related PRs
Description
Newer Descope accounts can't use the legacy client type on Federated (OIDC) and Inbound apps: creating one without
ClientTypegives them "confidential", and they can't switch an app back to legacy. This updates the SDK comments to say so.Must
🤖 Generated with Claude Code