Skip to content

feat(mgmt): support client type on OIDC applications - #822

Open
dorsha wants to merge 4 commits into
mainfrom
feat/oidc-app-client-type
Open

dorsha wants to merge 4 commits into
mainfrom
feat/oidc-app-client-type

Conversation

@dorsha

@dorsha dorsha commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/19288

Related PRs

Description

The SDK can now set the client type ("confidential" or "public") on Federated (OIDC) apps, which newer Descope accounts will require; Inbound apps already supported it. OidcApplicationOptions gains clientType, which createOidcApplication / updateOidcApplication already pass through since they spread the options. Loaded apps expose it as oidcSettings.clientType. Update replaces the whole app, so callers should pass the app's current client type on update.

Must

  • Tests
  • Documentation (if applicable)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: high


Review scope: Partial incremental re-review

Reviewed new changes (2)
  • README.md
  • lib/management/types.ts
Previously reviewed and unchanged: 1 file.

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: high

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread lib/management/types.ts Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant