Skip to content

feat(inboundapps): update client type in place unless public is involved - #425

Open
dorsha wants to merge 4 commits into
mainfrom
feat/inbound-app-client-type
Open

feat(inboundapps): update client type in place unless public is involved#425
dorsha wants to merge 4 commits into
mainfrom
feat/inbound-app-client-type

Conversation

@dorsha

@dorsha dorsha commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/19288

Related PRs

Description

Newer Descope accounts can no longer use the legacy empty client type, and when an app is created without a client type they now get a confidential one. So client_type on inbound and OIDC apps no longer defaults to "": if it's left out, Descope picks the type and Terraform keeps whatever is stored. Moving an inbound app from the legacy type to confidential updates it in place, keeping its client ID, and any other client type change still replaces the app.

In a Nutshell

  • client_type on inbound and OIDC apps: server picks when omitted
  • Replace inbound app unless moving legacy to confidential
  • Inbound and OIDC client_type docs: omitted value, newer accounts
  • Upgrade guide: in-place switch, secret rotation note
  • Acceptance and tfexport configs set confidential
  • Unit and acceptance tests for omitted type and replace rule

Must

  • Acceptance Tests (updated, not run locally)
  • Schema Compatibility
  • Documentation Updates

🤖 Generated with Claude Code

@dorsha @claude
feat(inboundapps): update client type in place unless public is involved
8b62213 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: high

Review scope: Partial incremental re-review

Reviewed new changes (16)
  • docs/raw/apps/oidc.md
  • docs/raw/inboundapp/inboundapp.md
  • docs/resources/inbound_app.md
  • docs/resources/oidc_app.md
  • internal/docs/docs.go
  • internal/models/apps/oidc.go
  • internal/models/apps/oidc_test.go
  • internal/models/inboundapp/inboundapp.go
  • internal/models/inboundapp/inboundapp_test.go
  • internal/models/apppermission/apppermission_test.go
  • internal/models/approle/approle_test.go
  • tools/tfexport/testdata/scenarios/apps/1.tf
  • tools/tfexport/testdata/scenarios/apps/2.tf
  • tools/tfexport/testdata/scenarios/inbound-app/1.tf
  • tools/tfexport/testdata/scenarios/inbound-app/2.tf
  • tools/tfexport/testdata/scenarios/kitchen-sink/1.tf
Previously reviewed and unchanged: 3 files.

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: high

shuni-bot[bot]
shuni-bot Bot reviewed Oct 19, 2026
View reviewed changes

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread internal/models/inboundapp/inboundapp.go Outdated
@dorsha @claude
fix(inboundapps): replace when the planned client type is unknown
6bf3228 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot reviewed Oct 19, 2026
View reviewed changes

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

This was referenced Oct 19, 2026
Open
Open
Open
@dorsha
dorsha enabled auto-merge (squash) October 19, 2026 06:58
@dorsha
dorsha requested a review from talaharoni October 19, 2026 07:01
talaharoni
talaharoni reviewed Oct 19, 2026
View reviewed changes
Comment thread internal/models/inboundapp/inboundapp.go Outdated
Comment thread templates/guides/upgrading-from-v0.3.md.tmpl Outdated
Comment thread internal/models/inboundapp/inboundapp_test.go
@dorsha @claude
fix(inboundapps): replace when the client type moves to legacy
a6b267e 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot reviewed Oct 20, 2026
View reviewed changes

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@dorsha @claude
feat(inboundapps): let the server choose the client type when it's om…
e4f8c15 
…itted

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shuni-bot[bot]
shuni-bot Bot reviewed Oct 21, 2026
View reviewed changes

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@aakashkulkarni aakashkulkarni mentioned this pull request Oct 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talaharoni talaharoni talaharoni left review comments
@shuni-bot shuni-bot[bot] shuni-bot[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dorsha @talaharoni