Repository navigation
fix(numbers): read a katakana コ alone after a number as the counter 個 - #809
Merged
Merged
Conversation
メール784コっす read 784코예요; the normalize step reads a コ right after a digit, a kanji numeral, 何 or 数 as 個 when no katakana follows it (784개예요, 三コ 세 개, 何コ 몇 개), and 3コース, 5コマ and 100コイン stay words. Blind Opus+Sonnet on 162 changed lines: 0 worse by both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A katakana コ after a number is 個 written in katakana. It was transliterated: メール784コっす 784코예요, 201コだよね 201코지, 446コの 446코의. This is a crit class from the 3,000-line mining (KO-COUNTER and KO-COUNTER-KO, 10 crit lines).
NormalizeForms (the normalize layer) now writes a コ as 個 when it comes right after a digit (ASCII or full-width), a kanji numeral (〇一…十百千), 何 or 数, and no katakana, ー or half-width katakana follows it. The word stage then reads the counter as usual: 784개예요, 三コください 세 개 주세요, 何コ 몇 개, １２コ 12개. Katakana words that start with コ after a number stay words: 3コース 3코스, 5コマ, 2コンボ, 100コイン, 3コスト, 3コロ.
A dictionary row for コ was tried first and dropped: it split unknown katakana runs (コダン 코 댄, ガチンコ 쨍그랑 코).
Not changed: 1コ上 (one year older) reads 1개상, and 二つ上 has the same problem. That's an age construction separate from this.
Spec: NUM-34. Cases: tests/rules/cases/ko-counter.tsv (15 rows: 8 fix and 7 keep).
Gate: build, ctest 76/76, rule and construction cases, examples, spec ids and --verify-dicts pass. Diff against develop 6755289 on 225,603 audit lines plus 46,245 pool lines: 154 lines change, plus 8 probe lines. Blind Opus+Sonnet on the 162: Opus 161 better and 1 same; Sonnet 161 better and 1 worse; 0 worse by both.