Repository navigation
Merged
Conversation
chore(release): merge main back into develop after 0.9.4
…ive 는다, fix comments (#782) Remove two construction rows that never fire on their own cases, re-point their cases to the rows that do, keep 1다간 out of the verb negative, fix misplaced comments and give two helpers internal linkage. Cleanup from the 0.9.4 post-release audit; no changed lines on the rule cases or mining sets.
…ed ている, and read a lexical causative す verb as itself in every form (#783) Keep the potential of a common transitive す verb in contracted forms (動かせてる → 움직일 수 있다) and read a lexical causative (尖らせてる) as the verb, fixing the #755 regression. Blind Opus+Sonnet on 72 changed lines: 0 worse by both; black-box battery: 0 worse.
…al's てはいる as 수는 있다 (#784) Read a lexical causative's せ before ながら as the verb (尖らせながら → 내밀면서) and keep a potential's てはいる as 수는 있다 (動かせてはいるが → 움직일 수는 있지만); てはいけない stays a prohibition. Blind Opus+Sonnet: 0 worse by both; black-box battery: 22 changed lines, all better, 0 guard lines changed.
…는 없습니다, and 遊ばせる with a person as 놀게 하다 (#785) Read a potential's てはいない in the present (隠せてはいない → 숨길 수는 없다) and てはいません as 수는 없습니다, and read 遊ばせる with a person or animal object, plurals included, as 놀게 하다. Pack class atoms now accept a class noun with a plural suffix. Blind Opus+Sonnet on 23 probe lines: 0 worse by both; black-box battery: 60 changed lines, all better, 0 guard lines changed; 0 of 8,000 pool lines changed.
… current Korean (#788) Read news, weather and politics words of captions by their current Korean (障害者 장애인, 弊社 저희 회사, 来月 다음 달, 与野党 여야, 日米韓 한미일), with context rows for 冷え込む (weather 추워지다, economy 얼어붙다, else 차가워지다), 首脳 and 始発. Blind Opus+Sonnet on 59 fresh caption lines: 0 worse by both; black-box battery: 24 of 25 changed guard lines better, the one worse line (被災地域) fixed.
…m and write loanwords in their familiar spelling (#791) Read caption sports words and loanwords in their familiar Korean (타임스, 맨해튼, 최연장, 일본에서 가장 높은 산, 배구공 with throwing verbs), ホーマー as 홈런 only in baseball, and fix 打つ (못을 박다, 공을 치다, 두다 only for go and chess), 運び出す with people (옮기다), 首相 → 총리 and 전/현/신임 title spacing. Blind Opus+Sonnet on 84 fresh caption lines: 0 worse by both; black-box battery: 0 defects worse by both (only ディール → 딜, kept by the loanword rule).
…ty from being read again by sound (#796) Count a katakana word that a pack row chose as read, so it is not read again by sound (ドジ踏んだ → 얼빠진 짓을 했다, not 도지 얼빠진 짓을 했다). Blind Opus+Sonnet: 1 changed line, better by both; black-box battery with 54 katakana collocations: 0 changed lines beyond the fix.
…words, part 1 (#787) Read common game and VN words by their current Korean (こっち 이쪽, with 여기 for a place you are in or going to; すいません 죄송해요; 一生 평생; ガキ 꼬맹이; 靴 신발, 구두 with a dress), add set phrases (こっちの身にもなれ 내 입장도 생각해라, ガキの頃 어릴 때, この間に 그사이에, 済みません 죄송합니다), and fix 並ぶ in a queue (줄을 서다) and the レジ/トヨタ/こら noun codes. Blind Opus+Sonnet on 957 fresh game lines: 0 worse by both; black-box battery: 0 real lines worse by both after rework.
…ng uses (#797) Read caption food words by their current Korean (이자카야, 굴튀김, 모둠회, 1월 초순) with context rows for コシ (탄력, 쫄깃함 with food), うまみ (감칠맛, 이점 with business), 旬 (제철, 요즘 뜨는 for people), こしょうする (후추를 치다, 고장 for machines), 添えてある (첨부되어, 곁들여져 with food) and 水揚げ. Blind Opus+Sonnet on 16 fresh caption lines: 0 worse by both; black-box battery: 0 worse by both.
…ay's Korean, part 2 (#793) Read game verbs, idioms and loanwords by their current Korean (撃たれる 총에 맞다, dropping 총에 after a non-person instrument; 力を入れる 힘을 쏟다, 힘을 주다 for body parts; 黙って 말없이/잠자코; 蘇る 되살아나다; 容赦ない 가차 없다), loanwords in standard spelling (실드, 콩쿠르, 새시, 시리어스, 케첩), and こっち/あっち/そっち + に/へ + a going verb as (으)로. Blind Opus+Sonnet on 615 fresh game lines: 1 worse by both (シリアス 진지함 → 시리어스, by the loanword rule); black-box battery: 0 worse by both.
… and other novel words by their usual sense (#786) Read web-novel words by their current Korean (洗い物 설거지, 大盛り 곱빼기, 侮る 얕보다, 援護 엄호 / 생활 지원, まじ 진짜, お任せ 맡겨 줘), with context rows for 加わる (합류 for people and forces, 더해지다 otherwise), グー (굿, 주먹 with punches, 꼬르륵 for a stomach), なまる, 共々 and 域, and set phrases such as お任せコース 오마카세 코스. Blind Opus+Sonnet on 142 fresh novel lines: 0 worse by both; black-box battery: 0 real lines worse by both after rework.
… conjugate 담다 and 머금다 as verbs (#799) Keep the て-form -어 before しまう/おく/みる/くれる after rule rows for 黙る, 振り返る and 安心する (黙ってしまった → 입을 다물어버렸다, not 다물고 버렸다), and conjugate 담다/머금다 as verbs (思いを込める → 마음을 담는다, not 담은다), keeping 담은 for the adnominal. Blind Opus+Sonnet on 20 changed lines: 0 worse by both; black-box battery: 26 changed lines, all better, 0 guard lines changed.
… and other novel words by their usual sense (#792) Read more web-novel words by their current Korean (寝込む 앓아눕다, 流れ着く 떠밀려 오다, 物知り 박식하다, 采配 지휘, 楽勝 식은 죽 먹기 / 손쉽게 이기다, 新 + loanword → 새 X for common ones), split ワザと by use (일부러, 고의적인, 기술과), read つかまつる in 하오체 (무례를 범하겠소), and turn に into 을/를 before 알현 after a person. Blind Opus+Sonnet on 39 fresh novel lines: 0 worse by both; black-box battery: 0 real lines worse by both.
…in a number after a counted katakana word to the next word (#800) Keep the space after a typed space when an empty お/ご prefix follows (あなた お車 → 당신 차), and join a number to a counted katakana word after Korean text (1ホーマー2ホーマー → 1홈런 2홈런), keeping label chains apart (월드 2 스테이지 5, 1승 2패). Blind Opus+Sonnet on 14 changed lines: 0 worse by both; black-box battery: 15 changed lines, all better.
…きさまら as 네놈들 and ていたんだ like ていた (#795) Conjugate stative Sino nouns as adjectives (充実している → 충실하다, 混雑していた → 혼잡했다), read お昼寝する as 낮잠 자다 and きさまら as 네놈들, read ていたんだ like ていた (食べていたんだ → 먹고 있던 거야) with the explanatory form of 行く defaulting to the state (トイレに行っていたんだ → 가 있던 거야), and keep a space after a drawn-out はぁぁ. Blind Opus+Sonnet on the changed fresh, pool and battery lines: 0 worse by both; black-box battery: 0 worse by both after rework.
Read everyday caption words by their current Korean (凄腕 실력자/실력 좋은, 隠しカメラ 몰래카메라, ボツ 퇴짜, 通気 환기, そば 메밀국수 for noodles, 見守り 돌봄), read おいら as a humble first person (나, 제가 in polite speech), 話がわかる by use (이해하다, 모르겠다, 말이 통하다 for a person), and V-たそばから as -자마자 for common verbs. Blind Opus+Sonnet on 65 fresh caption lines: 0 worse by both; black-box battery: 0 worse by both apart from one accepted cross-sentence polite line.
…分かってはいない as 알지는 못하다, 共 after a person as 들, and 起こす an animal as 깨우다 (#789) Read the てはいる paradigm of できる/来られる/行ける as 수는 있다/없다 in the present, 分かる/覚える てはいない as 알지는/기억하지는 못한다, 見える/聞こえる as 보이지는/들리지는 않다, 共 after a person as 들 (男共 남자들, 私共 저희), and 起こす as 일으키다 when the object fell (倒れた馬を起こした) and as 깨우다 for animals asleep. Blind Opus+Sonnet on 35 changed lines: 0 worse by both; black-box battery: 0 worse by both after rework.
… and the に before a 並ぶ of equals as (와)과 (#794) Read ている/ていた of change-of-state Sino verbs as a resulting state (全壊していた → 완파되어 있었다, 全壊した家 → 완파된 집, 沈没 → 침몰해 있다), keeping the progressive with process markers (最中, 今まさに, 徐々に), with an object, or with an agent subject (警察が封鎖している), and give 並ぶ 대등하다 its 와/과 particle. Blind Opus+Sonnet on 80 changed lines: 0 worse by both; black-box battery: 0 worse by both.
…atakana word by sound, and keep a kanji in parentheses that is no reading (#802) Read an unknown hiragana run by sound instead of dropping it when it follows a typed space or katakana and precedes a kanji or katakana word (キャンパスちば企画 → 캠퍼스 치바 기획, りんごねぷた列車 → 린고네푸타 열차), join nickname suffixes (サッちんの → 삿친의), leave kana verb forms alone, and keep a weekday in parentheses (28日（日） → 28일(일)). Blind Opus+Sonnet on the changed lines: 0 worse by both; black-box battery: 8 changed lines, all better.
…as 연말, 新幹線 as 신칸센 and other novel words by their usual sense (#801) Read more web-novel words by their current Korean (年の瀬 연말, 戦歴 전적, 新幹線 신칸센, なけなしの 얼마 안 되는), katakana idioms (ゴマをする 아부, サバを読む 나이를 속이다, ネコをかぶる 내숭을 떨다, ハッパをかける 다그치다) with literal uses kept, month counts (三月ぶり 석 달 만, 七月七日 7월 7일), and fix 謁見/見参 particles and ワザと leftovers. Blind Opus+Sonnet on 66 fresh novel lines: 0 worse by both; black-box battery: 0 worse by both apart from the kept てめー → 네놈 house form.
…one-off cues and same-reading rubies rename no other line (#790) Stop common words from becoming names in document mode (#781): a status field or window (力：35, 【力】 10) is never name evidence, a ruby equal to the ordinary reading is not evidence, a word also used in its common sense needs cues on two lines to spread and otherwise reads as a name only in person slots, and 樹 reads 수 by default, 나무 in tree contexts and 이츠키 in person slots. On the reporter's document, 力/敏捷/ジョブ/朝日/樹 name readings go from 98 lines to 0; name test documents failing drop from 51 to 19 of 99; blind Opus+Sonnet: 27 of 28 changed lines better by both, 0 worse.
…s, and 一月 after a year as 1월 (#803) Read kanji-numeral dates as digits with spacing (七月七日 → 7월 7일, 一月二十日 → 1월 20일, 二〇二〇年一月一日 → 2020년 1월 1일, 今月二日 → 이번달 2일), month spans for every month (三月後 → 석 달 후, 七月ほど → 일곱 달 정도), 〜ぶり as N 만 and 一日中 as 하루 종일, 一月 after a year as 1월, and 笑う with legs as 후들거리다 (笑いながら stays 웃으면서). Blind Opus+Sonnet on all changed lines: 0 worse by both; black-box battery: 62 changed lines, all better.
…verb, and a Vてみ before んな as みんな (#804) Read 言う after a non-quoting て as 말하다 (笑って言った → 웃어 말했다, not 웃어 했다; wrong since 0.9.3) while quoting って keeps 하다 (行くって言った → 간다고 했다), read 盛る/詰める before a noun as 담는 (込める keeps 담은), and stop Vてみ from eating みんな (振り返ってみんなを見た → 되돌아보고 모두를 보았다). Blind Opus+Sonnet on 71 changed lines: 0 worse by both; black-box battery: 29 changed lines, all better.
…es (#805) Replace case lines and spec rows that named an event, a train service, a TV segment, places or characters with invented lines of the same shape, checking the same behaviour. Test and spec text only; no engine or dictionary change.
… standard forms (#808) Read common Kansai forms: final や after a て form or imperative as a request (食えや → 먹어), んといて as 지 마 (気にせんといて → 신경 쓰지 마), final で after a past or ている (待っとったで → 기다리고 있었어), とりはせん, ん/とらん before やん/やろ (知らんやん → 모르잖아), ひん negatives (できひん → 할 수 없다), やんね and ええって, keeping standard や/で/ん. Blind Opus+Sonnet on 64 changed lines: 64 better by both, 0 worse; black-box battery: 37 changed lines, all better.
…at word (#806) Look a word up again when a ～/〜 or small vowel splits it (タ〜イム → 타임~, て～とく → 제독, かぁいい → 귀여워, 痛ぁい → 아파, お～いし～い → 맛있어~), while keeping cries, sound runs, long-vowel katakana, two-kana names and stutters (お～お前は → ~너는) as they were. Blind Opus+Sonnet on all changed lines: 0 worse by both; black-box battery: 32 changed lines, all better.
Transliterate a short hiragana speaker label in captions as a name ((しのぶ) → (시노부), さくら「…」 → 사쿠라, kana credits before feat.), while labels that are dictionary words, verb forms, stage directions or sounds stay words (（ははおや） → (어머니), まって「 → 기다려, （わらい）). Blind Opus+Sonnet on 76 changed lines: 0 worse by both; black-box battery: 0 worse by both after rework.
…#809) Read a katakana コ after a number as the counter 개 (784コ → 784개, 三コ → 세 개, 何コ → 몇 개, half-width ｺ too), keeping katakana words that start with コ (3コース, 5コマ, 100コイン, 3コーナー). Blind Opus+Sonnet on 162 changed lines: 0 worse by both; black-box battery: 24 changed lines, all better, 0 guard lines changed.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes develop 0cb3bd4 to main for 0.9.5 (patch).
Fixes issue #781: in document mode, common words were learned as names (力, 敏捷, 朝日, 樹, ジョブ). Status fields and windows are no longer name evidence, a same-reading ruby is not evidence, a word also used in its common sense needs cues on two lines to spread, and otherwise reads as a name only in person slots. Also a dictionary audit of web-novel, caption and game words, grammar (てはいる, 共, 起こす, resultative している, 言う after て), engine fixes (dropped hiragana runs, kanji dates, spacing), and four critical-error classes mined from fresh lines (mid-word stretch, kana speaker labels, Kansai forms, the コ counter).
Checks on the cut: CI green; on the #781 reporter's document, name misreadings 98 lines -> 0; eval2 critical 4.6% -> 4.6%, crit/major 34.9% -> 34.7%, worse by all three judges 2 -> 1; flip suite 496/592 (none lost); fresh fiction 14.0% -> 14.0%, captions 17.3% -> 17.1% critical vs 0.9.4; cycle held-out split (1,310 lines) 7.8% -> 7.6%, crit/major 36.7% -> 36.4%; mining set for the critical fixes (3,000 lines) 16.3% -> 15.7%; Opus review and black-box tests on every PR, and a release review of #782..#805 (GO); compute about the same as 0.9.4.
Pull requests: